Fix review issues: ValidationError assertion, clear_validate_cache import, GitHub Actions docs#274
Merged
p1c2u merged 2 commits intofeature/shortcut-cache-and-check-schema-fastpathfrom Mar 1, 2026
Conversation
…port, GitHub Actions doc Co-authored-by: p1c2u <1679024+p1c2u@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Speed up validate() with validator caching and optional schema-check
Fix review issues: ValidationError assertion, clear_validate_cache import, GitHub Actions docs
Mar 1, 2026
p1c2u
merged commit 00a1cce
into
feature/shortcut-cache-and-check-schema-fastpath
16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three review comments from PR #273 left the codebase with a misleading test assertion, a broken benchmark import, and a minor docs typo.
Changes
tests/unit/test_shortcut.py: Replace barepytest.raises(Exception)in the ECMA-regexcheck_schema=Falsepath withpytest.raises(ValidationError, match="is not a valid regular expression")— catches the right exception type and pins the expected message.benchmarks/run.py: Fix import and call of_clear_validate_cache→clear_validate_cache; the underscore-prefixed name never existed, causing anImportErroron any benchmark run.docs/contributing.rst: Correct "Github Action" → "GitHub Actions".💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.