notfy: give ack. about ruff linter and formatter#94
Merged
jhossbach merged 3 commits intopython-lsp:mainfrom Aug 24, 2024
Merged
notfy: give ack. about ruff linter and formatter#94jhossbach merged 3 commits intopython-lsp:mainfrom
jhossbach merged 3 commits intopython-lsp:mainfrom
Conversation
Contributor
Author
|
lol i thought my formatted did something but look like format needed for tests to past? |
Contributor
Author
|
Finally all checks passed |
Member
|
LGTM, thanks for your contribution! |
Contributor
Author
Yeah I knew but i didn't notice it is not configured when I was editing and committing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like inbuilt plugins, ruff will also inform about linter and formatter working
it is actually useful because it inform user that pylsp is working properly and format is also working