Enable building universal wheels#78
Merged
wbolster merged 1 commit intopython-happybase:masterfrom Jun 11, 2015
Merged
Conversation
Remove the use of execfile() in setup.py so it can run under python 3. Set the flag in setup.cfg to allow universal wheels.
Contributor
Author
|
Without this change in place, I see this error: |
Member
|
Thanks! FYI, Happybase only supported Python 2 because the Thrift library it depends on lacked Python 3 support. It seems that is now a thing of the past. |
Contributor
Author
|
I wasn't actually able to build wheels at all without the changes to setup.py. The "universal" flag was added as a "bonus". |
Member
|
I don't understand. Why would |
Contributor
Author
|
Ah, my default pip happens to be configured to point to python3, so if I run "pip wheel happybase" it fails. |
Member
|
Okay, I will merge this when I find time to get the other stuff required to release a version with Python 3 support done (#40). |
This was referenced Jun 10, 2015
wbolster
added a commit
that referenced
this pull request
Jun 11, 2015
Enable building universal wheels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the use of execfile() in setup.py so it can run under python 3.
Set the flag in setup.cfg to allow universal wheels.