Make KeyError tag#1398
Merged
Xithrius merged 8 commits intopython-discord:masterfrom Feb 11, 2021
anand2312:patch-1
Merged
Conversation
Akarys42
suggested changes
Feb 5, 2021
Contributor
Akarys42
left a comment
There was a problem hiding this comment.
Hello, thank you for your Pull Request! The tag content is quite good, although I wonder if it would be worth renaming the tag to dict-get or something like that.
I left a few comments related to formatting.
Contributor
|
Maybe include a example of >>> ages = {'Jim': 30, 'Pam': 28}
>>> ages['Michael']
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
KeyError: 'Michael' |
gustavwilliam
requested changes
Feb 6, 2021
Member
gustavwilliam
left a comment
There was a problem hiding this comment.
Thanks for the PR! This seems like a highly useful tag to have.
The tag looks good in general, but I have a few thoughts how we could perfect this, before going live.
Shivansh-007
approved these changes
Feb 9, 2021
Contributor
Shivansh-007
left a comment
There was a problem hiding this comment.
Thanks! Looks Good To Me!
Member
Xithrius
approved these changes
Feb 11, 2021
Member
Xithrius
left a comment
There was a problem hiding this comment.
Resolved all unresolved discussions, since almost every suggestion was eventually put into this new embed, or worked out.
Cool stuff!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.