Make results fully reproducible #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 76.27% 76.50% +0.22%
==========================================
Files 20 20
Lines 1332 1345 +13
==========================================
+ Hits 1016 1029 +13
Misses 316 316 ☔ View full report in Codecov by Sentry. |
juanitorduz
approved these changes
Jan 5, 2024
juanitorduz
reviewed
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems with doctests passing revealed that we were only passing the
random_seedkwarg to thepm.samplemethod and that this was not being passed intopm.sample_prior_predictiveorpm.sample_posterior_predictive.This will hopefully avoid any future issues in doctest fragility. But it is also a pretty useful (if not essential) fix to make.
Closes #284.