Merged
Conversation
Member
Author
|
Warnings status:
To do:
Yeah :( Trying to strike a compromise with my IDE's linter. The stickler objections here are wrong. Maybe a flake8 bug. |
mikofski
reviewed
May 3, 2019
pvlib/test/test_irradiance.py
Outdated
| warnings.simplefilter("ignore") | ||
| result = irradiance.get_extra_radiation(times, method='nrel', | ||
| how='numba', | ||
| numthreads=4) |
Member
There was a problem hiding this comment.
since you're making formatting changes, possibly consider:
result = irradiance.get_extra_radiation(
times, method='nrel', how='numba', numthreads=4)this is blacker code, tho not quite completely Black
Member
Author
There was a problem hiding this comment.
I agree this better formatting in this case. Overall, I prefer the grey zone.
Member
|
Everything lgtm so far, thanks! |
Member
Author
|
@cwhanse ready to merge if you approve of the last few commits. I'd like to keep the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.Avoid or silence a lot of test warnings, plus a few that users might encounter (
klucherandcalcparams_desotodivide by 0).Also some pep8 along the way. Waiting on #697.