Expand docstring for aoi_projection.#648
Merged
cwhanse merged 1 commit intopvlib:masterfrom Jan 21, 2019
adriesse:master
Merged
Expand docstring for aoi_projection.#648cwhanse merged 1 commit intopvlib:masterfrom adriesse:master
cwhanse merged 1 commit intopvlib:masterfrom
adriesse:master
Conversation
mikofski
reviewed
Jan 19, 2019
| Calculates the dot product of the solar vector and the surface | ||
| normal. | ||
| Calculates the dot product of the sun position unit vector and the surface | ||
| normal unit vector; in other words, the cosine of the angle of incidence. |
Member
There was a problem hiding this comment.
to improve this even slightly more, can you use LaTeX to add the equation?
$$AOI_{projection} = \\cos{ \\beta } \\cos{ \\left( \\text{ solar zenith } \\right) } + \\sin{ \\beta } \\sin{ \\left( \\text{ solar zenith } \\right) } \\cos{ \\left( \\text{ solar azimuth} \\right) - \\left( \\text{ surface azimuth} \\right) }$$
might require some creative thinking about symbols, and some text here or elsewhere to define them. Just an idea
Member
|
thanks @adriesse |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfile for all changes.