Conversation
|
Thanks for submitting this. The file maccrad format doesn't look like it was designed for ease of parsing. I can offer a couple of comments from looking at the file and code: The header section of the maccrad file looks like it could be of variable length, so you probably don't want to hardcode the 40. The leading # can be used to let read_csv skip the variable header section, but unfortunately the column names would be lost that way too. Is the number of columns always the same? In that case I would suggest using header=None and providing a standard name for each column. Your dateparser looks like it returns text. Does this produce a datetime index for the dataframe? I the time zone for the data in the file? "# Time reference: Universal time (UT)" Maybe the dataframe could be localized with this? |
|
Let's first start with a general feedback regarding design of io module.
I will use #271 to finalise the first input format and as we go improve design of the io module |
prototype for #261 & #29 (can these issues be merged?)
The data is here:
cd MY-GITHUB-CLONES
git clone https://github.com/dacoex/pvlib_data