Adopt ghi_clear variable name for clearsky GHI#2306
Conversation
|
Change to |
echedey-ls
left a comment
There was a problem hiding this comment.
I am pretty lost here:(
Kinda my fault for not documenting what I thought was obvious, sorry 😬
You have to rename the variables in the signature, see suggestions.
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
echedey-ls
left a comment
There was a problem hiding this comment.
Ignore the comment below, PR nailed, @RDaxini ! Well done using that random, undocumented decorator.
Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com>
Co-authored-by: Kevin Anderson <kevin.anderso@gmail.com>
…ython into ghi_clear_naming
|
I think we're good now |
Updates entries indocs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Also related: #1253, #2274