remove skip decorators for linux+python3 and pandas 0.18.0#187
Merged
wholmgren merged 3 commits intopvlib:masterfrom May 27, 2016
Merged
remove skip decorators for linux+python3 and pandas 0.18.0#187wholmgren merged 3 commits intopvlib:masterfrom
wholmgren merged 3 commits intopvlib:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scipy/scipy#6074 fixed a bug that caused the lambertw, and thus our singlediode function, to fail on Python 3 on linux. Thanks scipy devs! This PR removes the decorator function that skipped that test on the linux/py3 Travis-CI builds. See #109, #90 for the history.
There was also a bug in pandas 0.18.0 that required a test decorator. In principle this could be kept, but I'd prefer to avoid accumulating crap like this in the test suite. See #130 for the history.