Change input order of map_variables and url#1795
Merged
kandersolar merged 2 commits intopvlib:mainfrom Jun 30, 2023
Merged
Conversation
kandersolar
reviewed
Jun 30, 2023
Member
kandersolar
left a comment
kandersolar
left a comment
There was a problem hiding this comment.
For reference, this change is motivated by #1791 (comment)
| def get_psm3(latitude, longitude, api_key, email, names='tmy', interval=60, | ||
| attributes=ATTRIBUTES, leap_day=None, full_name=PVLIB_PYTHON, | ||
| affiliation=PVLIB_PYTHON, url=None, map_variables=None, | ||
| affiliation=PVLIB_PYTHON, map_variables=None, url=None, |
Member
There was a problem hiding this comment.
Note for posterity: url is new in get_psm3 in this version (#1736), so this isn't a change relative to 0.9.5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Tests added[ ] Updates entries indocs/sphinx/source/referencefor API changes.[ ] Adds description and name entries in the appropriate "what's new" file indocs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.