Handle kwargs for ModelChain.noct_sam_celltemp#1198
Merged
wholmgren merged 4 commits intopvlib:masterfrom Mar 16, 2021
Merged
Conversation
wholmgren
reviewed
Mar 16, 2021
pvlib/tests/test_modelchain.py
Outdated
Comment on lines
723
to
724
| assert m_noct_sam.call_args.kwargs == { | ||
| 'effective_irradiance': mc.results.effective_irradiance} |
Member
There was a problem hiding this comment.
Suggested change
| assert m_noct_sam.call_args.kwargs == { | |
| 'effective_irradiance': mc.results.effective_irradiance} | |
| assert m_noct_sam.call_args[1] == { | |
| 'effective_irradiance': mc.results.effective_irradiance} |
Member
There was a problem hiding this comment.
call_args.kwargs was added in python 3.8, so you have to use the old style look up for the older supported versions. If this doesn't work try
assert_series_equal(m_noct_sam.call_args[1]['effective_irradiance'], mc.results.effective_irradiance)
Member
Author
There was a problem hiding this comment.
Thanks. I was puzzled by the disconnect between pytest docs and the results, didn't think to check versions.
wholmgren
approved these changes
Mar 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[ ] Closes #xxxxdocs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Follow-on to #1195, closes the issue discussed here.