refactor ModelChain._prep_inputs_solar_pos for wx in poa solpos#1140
Merged
wholmgren merged 4 commits intopvlib:masterfrom Jan 22, 2021
Merged
refactor ModelChain._prep_inputs_solar_pos for wx in poa solpos#1140wholmgren merged 4 commits intopvlib:masterfrom
wholmgren merged 4 commits intopvlib:masterfrom
Conversation
Member
Author
|
Yes, sorry, didn't mean to suggest that it would close #1113, only that the same area of the code is relevant (among other parts). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).Also addresses style issue raised in #1135.
#1113 is also relevant to this PR because we'd end up explicitly passing the temperature data rather than optionally bundling it in kwargs.