improve PVSystem and associated object reprs#1031
Merged
wholmgren merged 3 commits intopvlib:masterfrom Aug 25, 2020
Merged
Conversation
Member
|
LGTM pending resolution of that odd test failure for py3.5. Thanks @wholmgren |
Member
Author
|
Ah, dictionary order is not guaranteed until 3.6. I'll specify a dict with a single key. |
kandersolar
reviewed
Aug 25, 2020
| (:pull:`1017`) | ||
| * Add :py:func:`pvlib.inverter.fit_sandia` that fits the Sandia inverter model | ||
| to a set of inverter efficiency curves. (:pull:`1011`) | ||
| * Added *racking_model*, *module_type*, and *temperature_model_parameters* to |
Member
There was a problem hiding this comment.
*racking_model* renders as italics on RTD. Doesn't matter to me, just fyi if those were supposed to be inline literals (double backticks).
Member
Author
There was a problem hiding this comment.
I intended for them to be italics but can change them if someone cares. I think too many inline literals make the whats new extremely hard to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/api.rstfor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).