Use replaceState for setting query params #266
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Fixes #61. This changes the
setQueryParametersto usereplaceState.setQueryParametersis only called on initial load viacreateSessionIdIfNecessary, so replacing the browser history state in this case seems like the right behavior (as opposed topushStatewhich would add an entry for thesessionId-less URL).Checklist:
GIFs
Using
replaceState(these changes)Chrome 97.0.4692.99
Firefox Developer 97.0b7