[PULP-1118] Add better error handling for repover duplicate content#7280
Open
[PULP-1118] Add better error handling for repover duplicate content#7280
Conversation
26e2e75 to
7e9e749
Compare
Added a proper error class for duplicate content handling and some more logging to inform exactly what are the conflicting content. Closes: pulp#7184
7e9e749 to
a42e341
Compare
dralley
reviewed
Feb 4, 2026
pulpcore/exceptions/base.py
Outdated
| """ | ||
|
|
||
| def __init__(self, duplicate_count: int, correlation_id: str): | ||
| self.dup_count = duplicate_count |
Contributor
There was a problem hiding this comment.
It would seem like this assumes that a RepositoryVersion creation failed due to duplicates always? Do we want to assume that? Should the error be more specific?
Member
Author
There was a problem hiding this comment.
Yeah, makes sense. I'll make more specific one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a proper error class for duplicate content handling and some more logging to inform exactly what are the conflicting content.
When duplicates are detected, we do some extra work to collect duplicate content.
A simple performance test shows it's not too bad:
Closes: #7184
📜 Checklist
See: Pull Request Walkthrough