Skip to content

Add GCP fake credentials#720

Closed
fao89 wants to merge 1 commit intopulp:mainfrom
fao89:gcpcred
Closed

Add GCP fake credentials#720
fao89 wants to merge 1 commit intopulp:mainfrom
fao89:gcpcred

Conversation

@fao89
Copy link
Member

@fao89 fao89 commented Jan 4, 2023

@fao89 fao89 requested a review from ipanova January 4, 2023 15:57
{%- if test_gcp %}

cat >> credentials.json << GCP_JSON
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just to understand this better, where this is taken from?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled in these changes into my pr and the issue seems to persist pulp/pulp_container#1196

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ipanova
Copy link
Member

ipanova commented Jan 9, 2023

@fao89 I don't think your changes are still enough, because pulp-container CI fails. Will you be able to test these changes on the example of pulp-container pulp/pulp_container#1196

@fao89 fao89 force-pushed the gcpcred branch 8 times, most recently from 589a43c to c83956b Compare January 11, 2023 21:56
[noissue]

Required PR: pulp/pulpcore#3481

Signed-off-by: Fabricio Aguiar <fabricio.aguiar@gmail.com>
@ipanova
Copy link
Member

ipanova commented Jan 20, 2023

@pulp/deployments if someone can take this over and finalize, it would be great. We have already merged the corresponding PR in core that states GCP is supported pulp/pulpcore#3481 hovewer we do not have a proof of a successful flow because the CI part was not done.

@fao89
Copy link
Member Author

fao89 commented Jan 20, 2023

actually, this PR is more related to @pulp/continuous-integration team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants