Add --ignore-paths and --extensions options#53
Add --ignore-paths and --extensions options#53redbeardcreator merged 5 commits intomasterfrom unknown repository
Conversation
src/Command/ScanCommand.php
Outdated
There was a problem hiding this comment.
I'm not sure why you're using array_filter() here. Are you expecting it to remove empty values? If so, that's fine, but it's a little obscure. I didn't realize it was usable like that until I just looked it up. I'd be tempted to refactor that bit (array_filter(explode(...))) into a separate method and document this use of array_filter(). But also see my other comments.
|
This looks great! I haven't tested yet, but a visual inspection looks good. I did have a minor question, but I think I answered it. Just in case I misread the second time, here it is. Why does |
|
The reason to use
one would use The csv solution was already in place with The latest commit removes the ignore-path and extension checks when the added path is a file name (as oposed to the result of a directory iteration). If you specify a file name to scan you simply want that file scanned... |
|
If there are no more suggested changes I feel this is ready to merge. |
Add --ignore-paths and --extensions options Looks good to me.
Add the possibility to ignore paths and specify file extensions to parse. Basically enhances the behaviour of
FileIterator.