Skip to content

Conversation

@Chaitanya1672
Copy link
Contributor

Fixes #3085

Changes:
Added an Escape key handler to the CodeMirror instance, enabling removal of focus from the editor upon pressing the 'Escape' key.

Steps to check:-

  1. Make focus on editor
  2. Press 'Esc' key
  3. Press 'Tab' key
    You will see user is able to move to console with tab key

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #3085

Demo Video:-

fix-editor.is.focus.trap.mp4

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this! We're hoping to update CodeMIrror over the summer, which should come with more accessibility updates and should address this issue as well. However, I think this could be a good temporary solution until that happens!

@raclim raclim merged commit f946073 into processing:develop May 31, 2024
@Chaitanya1672 Chaitanya1672 deleted the fixes/editor-is-a-focus-trap branch June 1, 2024 06:17
@raclim raclim mentioned this pull request Feb 12, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Editor is a focus trap

2 participants