Geometry Functions #55
Conversation
| global mesh | ||
| global grid_size | ||
| global offset | ||
| global spacing | ||
| global time |
There was a problem hiding this comment.
i don't like that we have to keep doing this. i want to figure out a way to declare a variable in setup() and have it available in draw() automagically.
There was a problem hiding this comment.
yeah, i agree it's not the best. i think it would be nice if more things could be declared at module scope.
you could look at nannous api for one example, where we require the user to return an explicit state / model object from setup.
| for z in range(grid_size): | ||
| for x in range(grid_size): | ||
| px = x * spacing - offset | ||
| pz = z * spacing - offset | ||
| mesh.color(x/grid_size, 0.5, z/grid_size, 1.0) | ||
| mesh.normal(0.0, 1.0, 0.0) | ||
| mesh.vertex(px, 0.0, pz) | ||
|
|
||
| for z in range(grid_size-1): | ||
| for x in range(grid_size-1): | ||
| tl = z * grid_size + x | ||
| tr = tl + 1 | ||
| bl = (z + 1) * grid_size + x | ||
| br = bl + 1 | ||
|
|
||
| mesh.index(tl) | ||
| mesh.index(bl) | ||
| mesh.index(tr) | ||
|
|
||
| mesh.index(tr) | ||
| mesh.index(bl) | ||
| mesh.index(br) |
There was a problem hiding this comment.
technically, i believe because of our awesome bevy system, this can all just go in draw() and it won't do more than it needs to. perhaps i'll move it back.
| pub fn new() -> PyResult<Self> { | ||
| let geometry = geometry_create(geometry::Topology::TriangleList) | ||
| .map_err(|e| PyRuntimeError::new_err(format!("{e}")))?; | ||
| Ok(Self { entity: geometry }) | ||
| } | ||
|
|
There was a problem hiding this comment.
So...this is half baked. What happens when we want to pass in other topologies. Or do we create special classes for each geometry mesh type? hmm. this question shouldn't block us from a demo
There was a problem hiding this comment.
I think we can just us kwargs to overload the constructor? So by default you could do Mesh() or you could do Mesh(topology=TRIANGLE_STRIP). Something like that.
tychedelia
left a comment
tychedelia
left a comment
There was a problem hiding this comment.
We should probably also add the module-level beginGeometry API as well: https://p5js.org/reference/p5/beginGeometry/
But looks great otherwise!
| global spacing | ||
| global time | ||
|
|
||
| camera_position(150.0, 150.0, 150.0) |
There was a problem hiding this comment.
Considering that we might want camera to be it's own entity similar to p5: https://p5js.org/reference/p5/createCamera/
| } | ||
|
|
||
| #[pyclass(unsendable)] | ||
| pub struct Mesh { |
There was a problem hiding this comment.
I'm happy to call this Mesh but we should rename the object name in libprocessing core.
| pub fn new() -> PyResult<Self> { | ||
| let geometry = geometry_create(geometry::Topology::TriangleList) | ||
| .map_err(|e| PyRuntimeError::new_err(format!("{e}")))?; | ||
| Ok(Self { entity: geometry }) | ||
| } | ||
|
|
There was a problem hiding this comment.
I think we can just us kwargs to overload the constructor? So by default you could do Mesh() or you could do Mesh(topology=TRIANGLE_STRIP). Something like that.
| } | ||
|
|
||
| pub fn draw_box(&self, x: f32, y: f32, z: f32) -> PyResult<()> { | ||
| let box_geo = geometry_box(x, y, z).map_err(|e| PyRuntimeError::new_err(format!("{e}")))?; |
There was a problem hiding this comment.
Yeah, if we want the immediate mode 3d, we should probably just pre-cache the shapes in libprocessing render but this totally works for now.
| .map_err(|e| PyRuntimeError::new_err(format!("{e}"))) | ||
| } | ||
|
|
||
| pub fn draw_mesh(&self, mesh: &Mesh) -> PyResult<()> { |
There was a problem hiding this comment.
would like to bikeshed over this name a bit. p5.js calls this function model, which isn't the most intuitive name but is concise.
2 participants
This is one tiny attempt at a nicer API. It definitely needs flushing out, but I thought a bit about the example that @tychedelia had come up with in the discord Link
And created a little something that doesn't involve the user having to specify a
Topology. This is just an idea, and needs some work.That said, it's ready for review and can be merged in with approval.
box.rsandanimated_mesh.rshave their counter python counterparts, so at least the bindings are in place.