feat: replace the header by a new header from material kit#923
Merged
feat: replace the header by a new header from material kit#923
Conversation
csouchet
added
enhancement
csouchet
force-pushed
the
637-Replace_the_header_by_a_new_header_from_Material_KIT
branch
from
0ba91bb to
770dd07
Compare
|
♻️ PR Preview 05d1f00 has been successfully destroyed since this PR has been closed.
🤖 By surge-preview |
csouchet
force-pushed
the
637-Replace_the_header_by_a_new_header_from_Material_KIT
branch
2 times, most recently
from
b0fe664 to
86a62d9
Compare
csouchet
force-pushed
the
637-Replace_the_header_by_a_new_header_from_Material_KIT
branch
5 times, most recently
from
d2ee054 to
024f38a
Compare
csouchet
removed
the
WIP 🚧
csouchet
force-pushed
the
637-Replace_the_header_by_a_new_header_from_Material_KIT
branch
4 times, most recently
from
10373de to
d72c2c3
Compare
- Use Material icon & not fontawesome
csouchet
force-pushed
the
637-Replace_the_header_by_a_new_header_from_Material_KIT
branch
from
d72c2c3 to
05d1f00
Compare
tbouffard
approved these changes
Mar 24, 2023
Member
tbouffard
left a comment
tbouffard
left a comment
There was a problem hiding this comment.
Header checks with the surge preview
- ✔️ desktop Firefox 111 on Ubuntu 20.04
- ✔️ mobile iPhone 8 iOS 16.3.1
ℹ️ there is a behavior change: the menu on the home page do not link to the section of this page.
The library entry is no more available in the header. As a consequence, the libraries section is no more highlighted as it was before. To be considered in the next PR.
csouchet
deleted the
637-Replace_the_header_by_a_new_header_from_Material_KIT
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding navbar, in the header, from https://demos.creative-tim.com/material-kit-pro/#/sections/navigation/navbars.
As decided with @tbouffard, we choose to merge the code like it is, to have a navbar who works in mobile view, for the Bonita Day. We clean the code and do improvment in other PRs.
Closes #637