-
Notifications
You must be signed in to change notification settings - Fork 9
Automate deps lock updates #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Looks pretty cool. Can it detect if the deps-lock is out of sync, though, and skip making unneeded commits? |
|
@KingMob if the content of deps-lock.json doesn't change as a result of the run then no commit will be created |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=======================================
Coverage 75.89% 75.89%
=======================================
Files 30 30
Lines 1535 1535
Branches 64 64
=======================================
Hits 1165 1165
Misses 306 306
Partials 64 64 ☔ View full report in Codecov by Sentry. |
a3c79fd to
fb23367
Compare
ships
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i was prepared to merge this earlier but can't seem to get the required checks to run despite having hit "approve and run".
What is the necessary authority to run these checks?
I'll contact @srounce sidechannel about commit lint.
fb23367 to
a29cd49
Compare
|
@ships I authorized the checks to run. Hopefully it will do that in the future, for at least this PR. |
The deps-lock.json file should be regenerated whenever deps.edn changes, rather than being edited by hand. This commit avoids having to manually do this chore by regenerating deps-lock.json automatically and commiting it to you branch. This automation is in an effort to avoid contributors getting blocked due to confusing errors when deps-lock.json has either not been regenerated or edited by hand.
a29cd49 to
40d6c79
Compare
|
This looks blocked because the CI GH actions aren't running. I'm going to try to jump start it. |
|
@srounce Can you check that you got the invitation to join the OpenGen GH group? It still shows as pending, which might be why your GH Actions jobs aren't running. Not sure. I tried seeing if I could forcibly restart your GH Actions, but I'm not seeing the relevant ones in the log anywhere. Failing that, it may be necessary to reopen this PR from a branch of OpenGen/GenSQL.query itself, instead of your fork. |
3dd319e to
3ff4919
Compare
3ff4919 to
f67869c
Compare
The deps-lock.json file should be regenerated whenever deps.edn changes, rather than being edited by hand. This commit avoids having to manually do this chore by regenerating deps-lock.json automatically and commiting it to you branch. This automation is in an effort to avoid contributors getting blocked due to confusing errors when deps-lock.json has either not been regenerated or edited by hand.
This also exposes clj-nix's
deps-locktool in the nix devshell to make it easier for people to run it manually if they need to during development.