Skip to content

Fix some issues in the documentation #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
zane wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix some issues in the documentation #73

zane wants to merge 2 commits into from

Conversation

@zane
Copy link
Contributor

@zane zane commented Dec 11, 2023 •
edited
Loading

@zane zane added the docs Improvements or additions to documentation label Dec 11, 2023
@zane zane requested a review from neeshjaa December 11, 2023 22:42
@zane zane self-assigned this Dec 11, 2023
@zane zane force-pushed the zane/fix-docs branch 3 times, most recently from ccbf832 to b681ef7 Compare December 11, 2023 23:38
Schaechtle
Schaechtle requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@Schaechtle Schaechtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see inline comment

docs/modules/ROOT/partials/base/scalar-expressions.adoc
SELECT PROBABILITY DENSITY OF VAR Apogee_km < 1000
UNDER model CONDITIONED BY VAR Users = "Military"
SELECT
PROBABILITY DENSITY OF VAR Apogee_km < 1000
Copy link
Contributor

@Schaechtle Schaechtle Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we're fixing this: PROBABILITY DENSITY OF VAR Apogee_km < 1000 will crash because PROBABILITY DENSITY takes a density event (i.e. involving equality). VAR Apogee_km < 1000 above is a distribution event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Schaechtle Schaechtle Schaechtle requested changes

@neeshjaa neeshjaa Awaiting requested review from neeshjaa

Requested changes must be addressed to merge this pull request.

Assignees

@zane zane

Labels

docs Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PROBABILITY Example Fails WITH Example Fails

3 participants

@zane @Schaechtle