Skip to content

Dont crash when importing markdown toolbar element #2403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
koddsson merged 8 commits into from
Nov 4, 2022
Merged

Dont crash when importing markdown toolbar element #2403

koddsson merged 8 commits into from
Nov 4, 2022

Conversation

@koddsson
Copy link
Contributor

@koddsson koddsson commented Oct 4, 2022

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2db9061

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 76.39 KB (0%)
dist/browser.umd.js 77.05 KB (0%)

@koddsson koddsson added the skip changeset This change does not need a changelog label Oct 4, 2022
@koddsson koddsson temporarily deployed to github-pages October 4, 2022 11:18 Inactive
@mattcosta7
Don't evaluate on every render
2db9061 
Co-authored-by: Matthew Costabile <mattcosta7@github.com>
@koddsson koddsson temporarily deployed to github-pages October 5, 2022 08:17 Inactive
@broccolinisoup
Copy link
Member

broccolinisoup commented Nov 3, 2022

👋🏼 @koddsson just wanted to check in and see if you need help from us with going forward with this PR?

@koddsson koddsson marked this pull request as ready for review November 4, 2022 09:57
@koddsson koddsson requested review from a team and colebemis November 4, 2022 09:57
@koddsson
Copy link
Contributor Author

koddsson commented Nov 4, 2022

👋🏼 @koddsson just wanted to check in and see if you need help from us with going forward with this PR?

I forgot to mark this as ready 😄

A review from @keithamus would be great if he wants this change into his PR since I'm targeting that branch.

keithamus
keithamus approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@keithamus keithamus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me 👍

@koddsson koddsson merged commit 75645c3 into move-markdown-toolbar-element-into-uncodnitional-render Nov 4, 2022
@koddsson koddsson deleted the dont-crash-when-importing-markdown-toolbar-element branch November 4, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colebemis colebemis Awaiting requested review from colebemis

1 more reviewer

@keithamus keithamus keithamus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

skip changeset This change does not need a changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@koddsson @broccolinisoup @keithamus