use git cat-file -e instead of git rev-list in _rev_exists

[ptarjan]

fixes #3604

https://git-scm.com/docs/git-cat-file

-e
Exit with zero status if <object> exists and is a valid object. If <object> is of an invalid format, exit with non-zero status and emit an error on stderr.

[asottile]

this causes output spew on missing / invalid revisions

[ptarjan]

How is that different than the current implementation?

~/github/pre-commit rev-list $ git rev-list --quiet abcde --
fatal: bad revision 'abcde'
~/github/pre-commit rev-list $ git cat-file -e abcde
fatal: Not a valid object name abcde

[ptarjan]

I mean I liked the == 0 since the docs explicitly talk about retuning 0 when the SHA exists but this is your project and I just want the functionality. I’ll switch back to not

…

On Fri, Dec 26, 2025 at 12:41 PM anthony sottile ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In pre_commit/commands/hook_impl.py <#3605 (comment)> : > - return not subprocess.call(('git', 'rev-list', '--quiet', rev)) + return not bool( + subprocess.call( + ('git', 'cat-file', '-e', rev), + stderr=subprocess.DEVNULL, + ), + ) not bool(...) is the same as not ... which you'll notice is *exactly what the original code does* — Reply to this email directly, view it on GitHub <#3605 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAJZT6M52IG7ENARCRZII34DW2QTAVCNFSM6AAAAACQCVVVUOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTMMJTHEZTAOBQHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[asottile]

do you actually understand what not 0 does? I'm more and more convinced you're just regurgitating llm nonsense and wasting my time. a human would have just changed the command and called it a day but instead we're somehow 10 commits deep

[asottile]

How is that different than the current implementation?

~/github/pre-commit rev-list $ git rev-list --quiet abcde --
fatal: bad revision 'abcde'
~/github/pre-commit rev-list $ git cat-file -e abcde
fatal: Not a valid object name abcde

You're absolutely right!