Closed
Conversation
Member
|
Thanks for opening this PR! Yeah, I agreed on this. Let me merge this into next version. |
Merged
Member
|
This is shipped as a5e48ae finally. Thanks for making improvement in a plugin support! |
Contributor
Author
|
Glad I helped :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
postcss-sprites use es6 and babeljs (and maybe there are other plugins do the same thing).
For modules compiled with babel, they may need to be required like this
So I just add one more check in the cli.