Merged
Conversation
…norepo into refactor-cli-logging
pileks
reviewed
Oct 10, 2022
Contributor
pileks
left a comment
pileks
left a comment
There was a problem hiding this comment.
Minor comments, everything looks great all-in-all! I'll open a PR with the proposed fixes.
| intlMsg.lib_helpers_docker_copyText(args), | ||
| intlMsg.lib_helpers_docker_copyError(args), | ||
| intlMsg.lib_helpers_docker_copyWarning(args), | ||
| async (_spinner) => { |
Contributor
There was a problem hiding this comment.
Probably want to rename this to _logger just for the sake of clarity? 😄 There's a few of these within the PR, ctrl+F spinner
Or just remove it as you've done in other places.
| intlMsg.lib_helpers_buildText(), | ||
| intlMsg.lib_helpers_buildError(), | ||
| intlMsg.lib_helpers_buildWarning(), | ||
| async (_spinner) => { |
Contributor
There was a problem hiding this comment.
Wouldn't we want to rename this to logger and pass it along into line 36 as the argument for the logger in runCommand? We ARE passing along the same thing, just a stylistic preference.
|
|
||
| export class DockerCompose { | ||
| private _dockerLock = getDockerFileLock(); | ||
| private _dockerLock = getDockerFileLock(new Logger({})); |
Contributor
There was a problem hiding this comment.
Any particular reason for passing an empty Logger here instead of an actual one?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #99