Centralize transform functions #5254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexcjohnson
reviewed
Nov 5, 2020
|
|
||
| lib.strTranslate = function(x, y) { | ||
| return (x || y) ? 'translate(' + x + ',' + y + ')' : ''; | ||
| }; |
Collaborator
There was a problem hiding this comment.
Might be able to simplify even more with an optional 3rd argument which is the number of digits to round to - would remove the Math.round and toFixed you have in a few places.
alexcjohnson
reviewed
Nov 5, 2020
alexcjohnson
approved these changes
Nov 5, 2020
Collaborator
alexcjohnson
left a comment
alexcjohnson
left a comment
There was a problem hiding this comment.
Nice simplification! 💃
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@plotly/plotly_js