include boxmode as valid attr#2396
Merged
cpsievert merged 2 commits intoplotly:masterfrom Dec 16, 2024
oliver-gray:patch/boxmode_layout_attr
Merged
include boxmode as valid attr#2396cpsievert merged 2 commits intoplotly:masterfrom oliver-gray:patch/boxmode_layout_attr
cpsievert merged 2 commits intoplotly:masterfrom
oliver-gray:patch/boxmode_layout_attr
Conversation
Contributor
Author
|
@cpsievert @KasperSkytte |
Collaborator
|
Yes, sorry, would you mind adding a |
Contributor
Author
|
Thanks! I've added this to the development version section of the News.md file. Hopefully that's as expected. |
|
Thank you! Does this also avoid the warning that is send for the related This is also mentioned #1956 and #2406 . Reproducible example for simple boxplots and grouped barplots shown below: |
Collaborator
|
No, do you want to submit a PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #2376 and #994.
Simply adds boxmode as a valid attribute option in the attrs_name_check function of utils.R.
Warning no longer appears for boxmode option.
Tests run without error or warning.
@cpsievert @KasperSkytte