Skip to content

dcc: refactor input#3398

Merged
KoolADE85 merged 10 commits intov4from
feature/dcc-refactor-input
Sep 2, 2025
Merged

dcc: refactor input#3398
KoolADE85 merged 10 commits intov4from
feature/dcc-refactor-input

Conversation

@KoolADE85
Copy link
Contributor

@KoolADE85 KoolADE85 commented Aug 8, 2025 •
edited
Loading

In this PR:

Contributor Checklist

  • I have broken down my PR scope into the following TODO tasks
  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md

@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 2b47c08 to 5a49f13 Compare August 8, 2025 23:22
@KoolADE85 KoolADE85 changed the title Feature/dcc refactor input dcc: refactor input Aug 8, 2025
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch 2 times, most recently from d7fa1ac to 01dac37 Compare August 11, 2025 16:36
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 01dac37 to 1653281 Compare August 11, 2025 17:01
@gvwilson gvwilson added P1 needed for current cycle fix fixes something broken labels Aug 11, 2025
KoolADE85
KoolADE85 commented Aug 12, 2025
View reviewed changes
dash/development/_generate_prop_types.py Outdated
values = str([v["value"] for v in prop_info["value"]])
return f"pt.oneOf({values})"
values = [v["value"] for v in prop_info["value"] if v.get("value") is not None]
return f"pt.oneOf([{",".join(v for v in values)}])"
Copy link
Contributor Author

@KoolADE85 KoolADE85 Aug 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes doubly-quoted strings in an enum of string literals

@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch 2 times, most recently from ffdf944 to 99e0e91 Compare August 12, 2025 22:48
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 99e0e91 to 7ec85f3 Compare August 12, 2025 23:24
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 1b336c2 to 0c175f5 Compare August 12, 2025 23:36
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 4f6b763 to 4a81cbe Compare August 19, 2025 14:37
@KoolADE85 KoolADE85 changed the base branch from dev to v4 August 21, 2025 18:31
@KoolADE85 KoolADE85 force-pushed the feature/dcc-refactor-input branch from 2367abf to 11d7d36 Compare August 21, 2025 18:54
@KoolADE85 KoolADE85 marked this pull request as ready for review August 21, 2025 19:48
@KoolADE85 KoolADE85 requested a review from camdecoster August 21, 2025 19:48
T4rk1n
T4rk1n reviewed Aug 22, 2025
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some minor comments.

components/dash-core-components/src/utils/_LoadingElement.tsx
*
* See: https://dash.plotly.com/loading-states#check-loading-states-from-components
*/
function LoadingElement({children}: LoadingElementProps) {
Copy link
Contributor

@T4rk1n T4rk1n Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is already a LoadingElement in js form, do we need both?

Copy link
Contributor Author

@KoolADE85 KoolADE85 Aug 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one, in typescript, is a slightly different pattern. So once all the components are migrated, I will remove the js version of this.

Copy link
Contributor

@T4rk1n T4rk1n Aug 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, maybe we can consolidate both, the whole idea behind the LoadingElement was to remove code duplication between the different components where the only difference was the html tag used (so we take it as prop and createElement).

T4rk1n
T4rk1n approved these changes Aug 25, 2025
View reviewed changes
Copy link
Contributor

@T4rk1n T4rk1n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can consolidate the loading element later on.

@KoolADE85 KoolADE85 merged commit 2444c36 into v4 Sep 2, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T4rk1n T4rk1n T4rk1n approved these changes

@ndrezn ndrezn Awaiting requested review from ndrezn ndrezn is a code owner

@gvwilson gvwilson Awaiting requested review from gvwilson

@emilykl emilykl Awaiting requested review from emilykl emilykl is a code owner

@camdecoster camdecoster Awaiting requested review from camdecoster

Assignees

@KoolADE85 KoolADE85

Labels

fix fixes something broken P1 needed for current cycle

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@KoolADE85 @T4rk1n @gvwilson