feat(tsdown): migrate from vendor sync to skills.sh#77
Conversation
Replace Type 2 vendor submodule with skills.sh-managed skill. - Remove vendor/tsdown submodule (rolldown/tsdown) - Remove tsdown entry from scripts/meta.ts vendors - Remove tsdown from SKILL_TO_PLUGIN in scripts/cli.ts - Install skill via `bunx skills add rolldown/tsdown --skill tsdown` - Move skills from skills/tsdown/ to .agents/skills/tsdown/ - Update plugin.json: add "skills" field, fix author/homepage/repository
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the tsdown skill from a git submodule-based vendor sync to a more modern skills.sh-managed approach. The changes are well-contained and correctly update the plugin configuration, remove the old submodule and sync scripts entries, and introduce the new skills-lock.json. This is a great improvement for maintainability. I've only found a couple of minor formatting issues that were likely unintentional.
| slidev: "slidev", | ||
| tsdown: "tsdown", | ||
| turborepo: "turborepo", | ||
| turborepo: "turborepo", |
There was a problem hiding this comment.
It looks like the indentation for this line was accidentally removed when deleting the line above. To maintain consistent code formatting, please restore the indentation.
turborepo: "turborepo",| }, | ||
| }, | ||
| "vuejs-ai": { | ||
| "vuejs-ai": { |
There was a problem hiding this comment.
Similar to the change in scripts/cli.ts, the indentation for this line seems to have been accidentally removed. Please add it back to keep the code formatting consistent.
| "vuejs-ai": { | |
| "vuejs-ai": { |
1 participant
Summary
vendor/tsdown) with skills.sh-managed skillbunx skills add rolldown/tsdown --skill tsdownplugins/tsdown/skills/tsdown/→plugins/tsdown/.agents/skills/tsdown/plugin.jsonto use"skills": "./.agents/skills/"fieldChanges
vendor/tsdowngit submodule (rolldown/tsdown)tsdownentry fromscripts/meta.tsvendorstsdownfromSKILL_TO_PLUGINinscripts/cli.tsplugins/tsdown/skills-lock.json(managed by skills.sh)plugins/tsdown/.claude-plugin/plugin.json: author, homepage, repository,skillsfieldWhy
Skills.sh approach is preferred over vendor sync because:
bunx skills updatewithout needing a git submodulebun scripts/cli.ts syncfor updatesTest
To update in the future:
Summary by cubic
Migrated tsdown from a vendor submodule to a skills.sh-managed skill for simpler updates and a direct source from rolldown/tsdown. This removes vendor sync and updates the plugin to load skills from .agents/skills.
Refactors
Migration
Written for commit 5628950. Summary will update on new commits.