Conversation
Allow --skill flag to accept multiple space-separated skill names. Running `bunx skills add` once per skill installs each into .agents/skills/<name>/ and appends to skills-lock.json. Example: /add-skill agent-skills https://github.com/vercel-labs/agent-skills --skill pr-review commit
Add Nuxt SEO meta-module plugin from onmax/nuxt-skills. Provides robots.txt, sitemap.xml, og-image, and schema-org (JSON-LD) capabilities for Nuxt projects. Install: /plugin install nuxt-seo@pleaseai
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
이 PR은 /add-skill 커맨드에 여러 스킬을 한 번에 추가하는 기능을 도입하고, 새로운 nuxt-seo 플러그인을 마켓플레이스에 추가합니다. 전반적으로 좋은 개선 사항들입니다. 다만 몇 가지 개선점을 발견하여 리뷰 댓글로 남겼습니다.
add-skill.md문서에서 여러 스킬 설치를 확인하는 명령어 예시를 더 명확하게 수정할 것을 제안합니다.nuxt-seo플러그인의plugin.json파일에서 원작자를 더 명확히 표기하도록 수정이 필요해 보입니다.nuxt-seo스킬 문서의 코드 예제에서 누락된 부분을 수정하여 완성도를 높일 수 있습니다.
Note: Security Review has been skipped due to the limited scope of the PR.
Add Step 6 to update README.md (Built-in Plugins section) and CLAUDE.md (if plugin source section exists) after adding a skill plugin. Summary step renumbered to Step 7.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="plugins/nuxt-seo/.agents/skills/nuxt-seo/SKILL.md">
<violation number="1" location="plugins/nuxt-seo/.agents/skills/nuxt-seo/SKILL.md:79">
P2: The related-skill link points to a non-existent local skill file, resulting in a broken reference.</violation>
</file>
<file name="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/schema-org.md">
<violation number="1" location="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/schema-org.md:130">
P2: The FAQ example uses `defineFAQPage()`, but the documented Nuxt Schema.org pattern is `defineQuestion()` with `defineWebPage({ '@type': 'FAQPage' })`; this can mislead users into using a non-standard helper.</violation>
</file>
<file name="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/og-image.md">
<violation number="1" location="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/og-image.md:130">
P3: The example uses `route.path` without defining `route`, so the copied snippet throws at runtime.</violation>
</file>
<file name=".claude/commands/add-skill.md">
<violation number="1" location=".claude/commands/add-skill.md:41">
P2: The repeated install step can fail on the second skill due to `cd` being reused across iterations in a persistent shell context.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
There was a problem hiding this comment.
7 issues found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".claude/commands/add-skill.md">
<violation number="1" location=".claude/commands/add-skill.md:161">
P3: The README insertion instruction is contradictory (`before the last plugin entry` vs `after the last`), which can lead to incorrect placement of new plugin docs.</violation>
</file>
<file name="plugins/nuxt-seo/.claude-plugin/plugin.json">
<violation number="1" location="plugins/nuxt-seo/.claude-plugin/plugin.json:10">
P3: The `license` field is set to `"NOASSERTION"` but the SKILL.md frontmatter explicitly declares `license: MIT`. Since the license is known, this should be `"MIT"` to maintain consistency. `NOASSERTION` is intended for cases where the license is genuinely unknown.</violation>
</file>
<file name="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/og-image.md">
<violation number="1" location="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/og-image.md:130">
P2: The example references `route.path` without defining `route`, so this copy-paste snippet is broken.</violation>
</file>
<file name="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/utilities.md">
<violation number="1" location="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/utilities.md:109">
P2: The Link Checker example uses an outdated config key (`exclude`) instead of the supported `excludeLinks`, which can cause users to copy a non-working configuration.</violation>
</file>
<file name="plugins/nuxt-seo/.agents/skills/nuxt-seo/SKILL.md">
<violation number="1" location="plugins/nuxt-seo/.agents/skills/nuxt-seo/SKILL.md:27">
P2: The skill references local `references/*.md` files that are missing, so the guidance contains dead links.</violation>
<violation number="2" location="plugins/nuxt-seo/.agents/skills/nuxt-seo/SKILL.md:79">
P3: The related skill link points to `../nuxt-content/SKILL.md`, but that file does not exist.</violation>
</file>
<file name="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/schema-org.md">
<violation number="1" location="plugins/nuxt-seo/.agents/skills/nuxt-seo/references/schema-org.md:160">
P2: The example uses `route.path` without defining `route`, so copied code will throw at runtime.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…ugin template Simplify plugin.json template and existing nuxt-seo plugin by removing author and repository fields.
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".claude/commands/add-skill.md">
<violation number="1" location=".claude/commands/add-skill.md:88">
P2: The Step 3 update removed repository metadata, but Step 2 still says `skills-lock.json.source` is used for plugin.json `repository`, leaving contradictory instructions.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Use subshell for cd in add-skill loop to prevent directory drift across iterations - Replace ls with find for multi-skill SKILL.md verification - Fix README insertion wording from "before" to "after" last plugin entry - Fix nuxt-seo plugin.json license from NOASSERTION to MIT
There was a problem hiding this comment.
1 issue found across 2 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".claude/commands/add-skill.md">
<violation number="1" location=".claude/commands/add-skill.md:58">
P2: The new verification command no longer validates each requested skill individually, so partial multi-skill installs can pass unnoticed.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
- Revert find to ls for per-skill SKILL.md validation so each requested skill is checked individually (find silently passes partial installs) - Remove reference to plugin.json repository field in Step 2 since Step 3 no longer includes that field in the template
1 participant
Summary
/add-skillcommand: The--skillflag now accepts multiple space-separated skill namesnuxt-seoskill fromonmax/nuxt-skillsto the marketplaceREADME.mdandCLAUDE.mdafter adding a skill pluginChanges
feat(commands): support multiple skills in add-skill command
The
--skillflag now accepts multiple skill names:Each skill runs
bunx skills addindividually and appends toskills-lock.json.feat(marketplace): add nuxt-seo plugin
Adds
nuxt-seoskill plugin fromonmax/nuxt-skills.Features:
Install:
feat(commands): add documentation update step to add-skill command
New Step 6 updates
README.md(Built-in Plugins section) andCLAUDE.md(if a plugin source section exists) after adding a skill plugin.Test plan
/add-skill--skill skill1 skill2nuxt-seoplugin and confirm skill auto-loads for Nuxt SEO tasks