feat(usePantry): Make versions take (PlainObject | string) | (PlainObject | string)[].

[rustdevbtw]

Makes the versions key to support a combination of PlainObject and string OR an Array of type Array<PlainObject | string>.

For example:

versions:
    - github: org/repo/releases
       strip: /v/
    - github: org/repo/tags
       strip: /v/

As well as:

versions:
    - github: org/repo/releases
       strip: /v/
    - github: org/repo/tags # Some version listed in tags, but without a proper release.
       strip: /v/
    - gitlab: org/repo/releases # Some version listed only in some GitLab repo releases
       strip: /v/
    - "1.0.0" # Some version listed nowhere, but exists

This all, while keeping full backwards compatibility! (hopefully)

[mxcl]

Seems like a solid addition with no trade-offs I can think of, but maybe @jhheider can imagine some

[rustdevbtw]

Seems like the PIP CI is having issues (definitely not related to it, because it only applies to pkg build, at the start, and the error occurs at a later part).

[mxcl]

yeah pip has had problems every build recently. We should probably pin all these builds to known buildable versions

[rustdevbtw]

@mxcl Except the PIP one, every other test seems to pass.

[mxcl]

Yep we can merge if @jhheider agrees with me that this seems safe and good

[rustdevbtw]

@mxcl I added additional tests (to confirm it works) for usePantry.getVersions.

[jhheider]

The code change looks good. We should try to keep style changes out of logic changes.

[jhheider]

Yep we can merge if @jhheider agrees with me that this seems safe and good

Yeah, we discussed at length on discord. I think this gives us some great options without altering existing parsing.

[rustdevbtw]

I've applied these changes. As for style stuff, I've Deno autoformatting enabled, so it formatted that.

[rustdevbtw]

Anything else?

[jhheider]

If mxcl is ok with all the autoformating, I'm ok with the logic.

[rustdevbtw]

Oh no, I didn't see the Deno permissions. I think I've to remove that test for now.

[jhheider]

Oh no, I didn't see the Deno permissions. I think I've to remove that test for now.

Can we add the permission we need? Better to test than not.

[rustdevbtw]

Oh no, I didn't see the Deno permissions. I think I've to remove that test for now.

Can we add the permission we need? Better to test than not.

Just added that

[rustdevbtw]

Seems like permissions aren't just enough. Doing github version checks require GH_TOKEN as well.

[rustdevbtw]

@jhheider Can you try again please?

[mxcl]

If mxcl is ok with all the autoformating, I'm ok with the logic.

It's not cool, but we'll live. In general, in open source, you adopt the project’s styling, you don’t impose your own.

[rustdevbtw]

If mxcl is ok with all the autoformating, I'm ok with the logic.

It's not cool, but we'll live. In general, in open source, you adopt the project’s styling, you don’t impose your own.

I actually didn't even know that I had autoformatting enabled before @jhheider mentioned the styling