Merged
Conversation
Based on #12, and sifting through online conversatino [like this](https://unix.stackexchange.com/questions/285575/whats-the-difference-between-a-flag-an-option-and-an-argument), this refactor proposes using the terminology "args" for options that take arguments, and "flags" for options that are boolean. Fixes #12
Collaborator
Author
|
CC: @shadowspawn |
Collaborator
|
Short version: I think it is an improvement. 👍 |
ljharb
approved these changes
Dec 4, 2021
Member
ljharb
left a comment
There was a problem hiding this comment.
I would say that "args" is an umbrella term that includes flags. it's "yargs", not "yvalues" or "yparams" :-p
Collaborator
|
To expand a little:
Seconding that viewpoint, the routine we are implementing is called |
Collaborator
|
Of note for consistency, the configuration property for setting up the parsing is called |
Collaborator
Author
|
so we're leaning towards |
iansu
approved these changes
Dec 6, 2021
Collaborator
Author
|
@iansu @shadowspawn @ljharb take a look. |
Collaborator
|
LGTM (Changed title to match latest code.) |
Eomm
approved these changes
Dec 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #12, and sifting through online conversations like this, this refactor
proposes using the terminology "args" for options that take arguments,
and "flags" for options that are boolean.
Fixes #12