Conversation
bcoe
commented
Nov 14, 2021
iansu
approved these changes
Nov 14, 2021
Collaborator
iansu
left a comment
There was a problem hiding this comment.
Nice! Do we want to publish the eslint plugin and/or move it to the pkgjs org before merging this?
Collaborator
Author
Collaborator
Author
|
_Note: we should probably opt for |
Eomm
approved these changes
Nov 14, 2021
joesepi
approved these changes
Nov 15, 2021
| } | ||
|
|
||
| let result = { | ||
| const result = { |
Collaborator
Author
There was a problem hiding this comment.
I think so, this edit was made automatically by linter.
Collaborator
Author
|
@iansu we can follow up getting rid of the git dependency. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a linter that enforces a coding style closer to Node core's.
Note: this will make it easy to drop code directly into the codebase when the time comes.
Fixes #3