Merged
Conversation
* made picture in picture btn dependent on whether PIP in avaiable in client browser * refactor/clean up removing functions to save and adding callback at parent component * comment out save btn * Removed commented out code, updated README * updated storybook * removed state updated + word timecodes resync race condition in autoSave * added utility for local-storage save * fixed bug * loacal storage save, for demo only only works with laodDemo, other import from computer etc.. still not addressed * Removed spacing * first pass * renamed autoSaveFormat to autoSaveContentType * speaker label with 100% * refactored to change layout based on audio or video player * fixed webpack * quick fix demo app * Update README.md Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating from BBC master