Draft
Conversation
* fixes issue #133 * Working if isEditable is true can edit speaker label, if false, cannot * adjusted CSS accordingly * moved CustomEditor in separate file * speaker prompt keeps current speaker name * brought in changes from previous PRs master...philmcmahon:update-all-speakers#diff-cdf6a9957d22ff2efacaaf5fb2876a8aR58 it works but does not seem to rerender after change * names change but component doesn't re-render * changes don't propagate straight away but they do after you edit text * cleaned up still no auto re-rendering * works added shoudl component update and component did mount in wrapper block to update speaker label * changing spekaer triggers auto save callback * Removed space * Update packages/components/timed-text-editor/CustomEditor.js Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com> * Update packages/components/timed-text-editor/WrapperBlock.js Co-Authored-By: Eimi Okuno <emettely@users.noreply.github.com>
* changed james to be point of contact for QA issues * updated player controls * updated images
… empty transcription
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your Pull Request request related to another issue in this repository ?
Describe what the PR does
viewing diffs
State whether the PR is ready for review or whether it needs extra work
NA
Additional context
NA