Scan all array literals for language keys#96
Merged
paul999 merged 3 commits intophpbb:masterfrom Sep 22, 2023
Merged
Conversation
paul999
approved these changes
Oct 10, 2019
paul999
approved these changes
Oct 14, 2019
Member
Dark1z
suggested changes
Mar 5, 2021
| if ($item->key instanceof String_) | ||
| { | ||
| $this->keys[] = $item->key->value; | ||
| } |
There was a problem hiding this comment.
there is no else to output Err0r message using this $this->output->addMessage(...).
Like in line : https://github.com/phpbb/epv/pull/96/files#diff-e1b04a6070a8aea621fb26a83bd723de8f86c5957aef5b1952a9910c0e0e84a5L142
| $this->keys[] = $item->key->value; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
there is no else to output Err0r message using this $this->output->addMessage(...).
Like in line : https://github.com/phpbb/epv/pull/96/files#diff-e1b04a6070a8aea621fb26a83bd723de8f86c5957aef5b1952a9910c0e0e84a5L148
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of extracting language keys only from arguments to
array_merge(), with this change, string keys from all array literals in the file will be collected and interpreted as being language keys.