Skip to content

Allow _defaults declaration under services#105

Merged
iMattPro merged 4 commits intophpbb:masterfrom
iMattPro:update
Oct 19, 2021
Merged

Allow _defaults declaration under services#105
iMattPro merged 4 commits intophpbb:masterfrom
iMattPro:update

Conversation

@iMattPro
Copy link
Member

@iMattPro iMattPro commented Oct 3, 2021

Some extension developers are starting to use Autowiring. That requires a _defaults declaration under services:

services:
    _defaults:
        autowire: true

This change will serve to allow that, and prevent the following false error:

Warning: The service name should start with vendor.namespace (which is vendorname.extensionname) but started
with _defaults in /vendorname/extensionname/config/services.yml

Also there are some additional code improvements and error message corrections in this test.

@iMattPro iMattPro merged commit 8e8d821 into phpbb:master Oct 19, 2021
@iMattPro iMattPro deleted the update branch October 19, 2021 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants