-
Notifications
You must be signed in to change notification settings - Fork 613
Modernize top half of Thanks page #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I wouldn't worry too much about the size on mobile. I'm more asking myself whether there is a possibility to randomize an unordered list via CSS. So that not always the same sponsors are "above the fold". Or at the top of the list on mobile. |
|
This looks great! Thank you!
I wouldn't really worry about IE11; I doubt many PHP developers are using that to browse php.net, and even if someone uses IE11, they still get the info.
FWIW, that could be done on the server. |
Would be a nice followup contribution to keep scope for this PR limited :) |
They use it in the favicon so I assume this is their logo. https://www.servercentral.net/assets/images/mark.svg I randomly found this PR, and it looks better than current one. |
|
👍 |
|
Hi all, I resolved the conflict and added the missing logo. If there are no objections, I'll merge this PR, |
cmb69
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks great!



In issue #682 it was requested to modernize the thanks page; as a first
step in this effort I have given the top half of the page with current
sponsors a brush up, including responsive behaviour.
Unfortunately I could not find a logo for ServerCentral; so I left that
empty.
The improvements in this PR does use CSS Grids, meaning it won't
show up exactly the same way in IE11 compared to other browsers.
I have taken this as a given and unfortunate thing, but I do not know
whether this is an issue as I do not know the browserlist.
If the above is an issue, let me know and I'll invest more time on how
it looks on IE11.