Skip to content

Conversation

@mvriel
Copy link
Contributor

@mvriel mvriel commented Aug 6, 2022

In issue #682 it was requested to modernize the thanks page; as a first
step in this effort I have given the top half of the page with current
sponsors a brush up, including responsive behaviour.

Unfortunately I could not find a logo for ServerCentral; so I left that
empty.

The improvements in this PR does use CSS Grids, meaning it won't
show up exactly the same way in IE11 compared to other browsers.
I have taken this as a given and unfortunate thing, but I do not know
whether this is an issue as I do not know the browserlist.

If the above is an issue, let me know and I'll invest more time on how
it looks on IE11.

In issue php#682 it was requested to modernize the thanks page; as a first
step in this effort I have given the top half of the page with current
sponsors a brush up, including responsive behaviour.

Unfortunately I could not find a logo for ServerCentral; so I left that
empty.

Fixes php#682
@mvriel
Copy link
Contributor Author

mvriel commented Aug 6, 2022

Desktop

image

Tablet (Portrait)

Mobile

As for mobile, I am a bit on the fence if the cards aren't too big. Feedback is appreciated, to show it nicely with logo's is a bit of a thing on mobile if you want to keep it small :)

@heiglandreas
Copy link
Contributor

I wouldn't worry too much about the size on mobile.

I'm more asking myself whether there is a possibility to randomize an unordered list via CSS. So that not always the same sponsors are "above the fold". Or at the top of the list on mobile.

@cmb69
Copy link
Member

cmb69 commented Aug 8, 2022

This looks great! Thank you!

If the above is an issue, let me know and I'll invest more time on how
it looks on IE11.

I wouldn't really worry about IE11; I doubt many PHP developers are using that to browse php.net, and even if someone uses IE11, they still get the info.

I'm more asking myself whether there is a possibility to randomize an unordered list via CSS.

FWIW, that could be done on the server.

@mvriel
Copy link
Contributor Author

mvriel commented Aug 8, 2022

I'm more asking myself whether there is a possibility to randomize an unordered list via CSS.

FWIW, that could be done on the server.

Would be a nice followup contribution to keep scope for this PR limited :)

@RobiNN1
Copy link

RobiNN1 commented Aug 25, 2022

Unfortunately I could not find a logo for ServerCentral; so I left that
empty.

They use it in the favicon so I assume this is their logo.

https://www.servercentral.net/assets/images/mark.svg

mark

I randomly found this PR, and it looks better than current one.

@samdark
Copy link
Contributor

samdark commented Oct 17, 2022

👍

@saundefined
Copy link
Member

Hi all, I resolved the conflict and added the missing logo.

If there are no objections, I'll merge this PR,
if there are comments — I'll try to quickly fix :)

@saundefined saundefined requested a review from cmb69 October 17, 2022 11:40
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants