Enhancement: Enable trailing_comma_in_multiline fixer
#647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
force-pushed
the
feature/trailing-comma-in-multiline
branch
2 times, most recently
from
5d74c84 to
81ae171
Compare
cmb69
reviewed
Jul 12, 2022
2 tasks
localheinz
force-pushed
the
feature/trailing-comma-in-multiline
branch
from
afbb9df to
8d02eae
Compare
Member
|
This has many conflicts. |
saundefined
added
Waiting on Author
Status: Needs Feedback
and removed
Waiting on Author
labels
localheinz
force-pushed
the
feature/trailing-comma-in-multiline
branch
from
dea508a to
02d44eb
Compare
Contributor
Author
|
Rebased! |
Girgias
reviewed
Dec 6, 2023
Girgias
reviewed
Dec 6, 2023
Member
Girgias
left a comment
Girgias
left a comment
There was a problem hiding this comment.
Mostly LGTM, just a couple of questions
localheinz
force-pushed
the
feature/trailing-comma-in-multiline
branch
from
c48e3f1 to
76baa32
Compare
Member
|
Needs a rebase again |
localheinz
force-pushed
the
feature/trailing-comma-in-multiline
branch
from
c29855a to
f07cfcb
Compare
Contributor
Author
|
Rebased, @Girgias! |
localheinz
commented
Dec 6, 2023
| 'trailing_comma_in_multiline' => [ | ||
| 'elements' => [ | ||
| 'arguments', | ||
| 'arrays', |
Contributor
Author
There was a problem hiding this comment.
Since we use PHP 8.2 now, we could also add
matchparameters
to the elements option.
Member
There was a problem hiding this comment.
I think this probably makes sense as a follow-up PR to not clog this up any longer
Contributor
Author
|
Thank you, @cmb69, @derickr, @Girgias, and @saundefined! |
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
trailing_comma_in_multilinefixermake coding-standardsFollows #559.
💁♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.40.2/doc/rules/control_structure/trailing_comma_in_multiline.rst.