Skip to content

Conversation

@localheinz
Copy link
Contributor

@localheinz localheinz commented Jul 8, 2022

This pull request

  • adds a Makefile

πŸ’β€β™‚οΈ Run

make

or

make help

to show a list of available commands.

Run

make tests

to run the existing tests.

@grep -E '^[a-zA-Z0-9_-]+:.*?## .*$$' $(MAKEFILE_LIST) | sort | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[32m%-30s\033[0m %s\n", $$1, $$2}'

.PHONY: tests
tests: ## Runs tests
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see #615.

Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This makes sense to me. (Although Windows users won't be able to use it, but I assume that isn't a real problem.)

@localheinz localheinz force-pushed the feature/make branch 2 times, most recently from ab5e15a to ed16063 Compare July 8, 2022 21:34
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@localheinz
Copy link
Contributor Author

@cmb69

Once this has been merged, I can update #559 - or the other way around!

@cmb69 cmb69 merged commit dc0eb0f into php:master Jul 11, 2022
@cmb69
Copy link
Member

cmb69 commented Jul 11, 2022

Thanks for this PR! I'll have a look at #559 soon.

@localheinz localheinz deleted the feature/make branch July 11, 2022 12:27
@localheinz
Copy link
Contributor Author

localheinz commented Jul 11, 2022

Thank you, @cmb69!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants