Skip to content

Fix: Remove useless function #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cmb69 merged 1 commit into from
Jul 2, 2022
Merged

Fix: Remove useless function #584

cmb69 merged 1 commit into from
Jul 2, 2022

Conversation

@localheinz
Copy link
Contributor

@localheinz localheinz commented Jun 28, 2022

This pull request

  • removes a useless function manual_header()

kamil-tekiela
kamil-tekiela approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@kamil-tekiela kamil-tekiela left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM I wonder though if it impacts translations.

@localheinz
Copy link
Contributor Author

localheinz commented Jun 28, 2022

@kamil-tekiela

LGTM I wonder though if it impacts translations.

How can I find out if any of them is using this stuff?

@cmb69
Copy link
Member

cmb69 commented Jun 28, 2022

That would break the manual, since every single manual page calls this function. Note that files under manual/en are just a few examples; the actual files are rendered by PhD, and there we would need to delete this line: https://github.com/php/phd/blob/c3868a838e5029e7cbe39868a1c146e9b81c4986/phpdotnet/phd/Package/PHP/Web.php#L207

After that has been done, and the manual has been successfully rebuilt (happens every 4 or 6 hours), we can merge this PR.

@kamil-tekiela
Copy link
Member

kamil-tekiela commented Jun 28, 2022

I thought so. Let's leave it as it is for now.

@localheinz localheinz mentioned this pull request Jun 28, 2022
Merged
1 task
@localheinz
Copy link
Contributor Author

localheinz commented Jun 28, 2022

@cmb69 @kamil-tekiela

See php/phd#66!

@cmb69 cmb69 mentioned this pull request Jul 2, 2022
Closed
1 task
@cmb69 cmb69 merged commit c3f9653 into php:master Jul 2, 2022
@localheinz localheinz deleted the fix/useless branch July 2, 2022 10:26
@localheinz
Copy link
Contributor Author

localheinz commented Jul 2, 2022

Thank you, @cmb69 and @kamil-tekiela!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kamil-tekiela kamil-tekiela kamil-tekiela approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@localheinz @cmb69 @kamil-tekiela