Skip to content

Conversation

@localheinz
Copy link
Contributor

@localheinz localheinz commented Jun 27, 2022

This pull

  • stops overriding the default vertical-align: top with vertical-align :middle for table cells

Somewhat related to #499.

πŸ’β€β™‚οΈ For reference, see

table td {
vertical-align:top;
}

Before

CleanShot 2022-06-27 at 15 27 48@2x

After

CleanShot 2022-06-27 at 15 28 04@2x

❗ This affects other tables using class="standard" as well.

@localheinz localheinz force-pushed the fix/vertical-align branch from d345322 to 3553f59 Compare June 27, 2022 13:20
@cmb69
Copy link
Member

cmb69 commented Jun 27, 2022

Hmm, looks strange on https://www.php.net/docs.php (although that shouldn't be a table, in my opinion).

@localheinz
Copy link
Contributor Author

@cmb69

You are right, it looks a bit strange.

CleanShot 2022-06-27 at 19 27 16@2x

Perhaps it would make sense to get rid of the standard class, too. There are not that many tables using the standard class. Default seems standard enough!

@cmb69
Copy link
Member

cmb69 commented Jun 27, 2022

Perhaps it would make sense to get rid of the standard class, too. There are not that many tables using the standard class. Default seems standard enough!

Maybe. But regarding this table, see PR #560.

@morrisonlevi
Copy link
Contributor

Hmm. For what it's worth, on the EOL page at least, I definitely prefer the vertical-align: middle. It seems easier to read for whatever reason.

@localheinz localheinz force-pushed the fix/vertical-align branch from 3553f59 to c6cf259 Compare July 8, 2022 20:43
@localheinz
Copy link
Contributor Author

Closing in favour of #499.

@localheinz localheinz closed this Oct 21, 2022
@localheinz localheinz deleted the fix/vertical-align branch October 21, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants