Single blank line at eof #541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A PHP file without end tag must always end with a single empty line feed.
kamil-tekiela
approved these changes
Jun 17, 2022
Member
kamil-tekiela
left a comment
kamil-tekiela
left a comment
There was a problem hiding this comment.
Looks good but one of your other PRs did the exact opposite. Could you not make a single PR with all the changes and also commit the CS-fixer file?
Contributor
|
How do you feel about adding an root = true
[*]
insert_final_newline = true |
Member
|
I think an .editorconfig would be less controversial that a CS-fixer configuration. |
Member
|
Thank you! |
1 task
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A PHP file without end tag must always end with a single empty line feed.