Fix content layout on pages without sidebars for 768-979px viewport widths #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
👍 |
cmb69
reviewed
Oct 17, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Ugh, this nice fix has apparently been overlooked. @SteveDesmond-ca, could you please fix the merge conflict?
Contributor
Author
|
@cmb69 No worries, I luckily still had my PR branches around! |
Member
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #500, pages without sidebar content (in an
asidetag) are still pushed to the side at 70% width. I believe this is due to an over-eager selector (the one line changed in this PR).The combination of
#layout-contentand:only-childis used in multiple places elsewhere in the site's CSS files, so I figured that was the safest option to minimize the amount of code being changed.