Enhancement: Document platform requirement in composer.json
#408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localheinz
commented
May 25, 2021
localheinz
commented
May 25, 2021
localheinz
force-pushed
the
feature/composer
branch
2 times, most recently
from
aaf5f14 to
009dae2
Compare
localheinz
changed the title
composer.json
localheinz
force-pushed
the
feature/composer
branch
from
009dae2 to
cb9068a
Compare
Contributor
Author
|
Are there any objections to merging this pull request? |
Member
|
Why is composer.lock committed? |
Contributor
Author
localheinz
force-pushed
the
feature/composer
branch
from
cb9068a to
2de9a9c
Compare
localheinz
commented
Jun 17, 2022
localheinz
commented
Jun 17, 2022
cmb69
reviewed
Jun 17, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
I'm generally in favor of adding a composer.json, and if we declare config.platform.php, committing composer.lock appears to be a good idea as well.
This was referenced Jun 27, 2022
localheinz
force-pushed
the
feature/composer
branch
from
2de9a9c to
14ab35e
Compare
cmb69
reviewed
Jul 4, 2022
cmb69
approved these changes
Jul 6, 2022
Member
cmb69
left a comment
cmb69
left a comment
There was a problem hiding this comment.
Thank you! This is fine for me.
Member
|
Thank you! |
Contributor
Author
|
Thank you, @carusogabriel, @cmb69, @Girgias, and @kamil-tekiela! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
composer.jsonFollows #606 (comment).
💁♂️ This project currently does not use
composerto manage its dependencies, but it does not need to stay that way. Apart from usingcomposerto manage dependencies,composer.jsonalso serves documentation purposes. For a start, I propose to addcomposer.jsonwith platform requirements - we can take it from there, if that make sense for you.