Skip to content

Update hero section styles according to BEM methodology #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sy-records merged 2 commits into from
Oct 30, 2024
Merged

Update hero section styles according to BEM methodology #1107

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0bdc32
feat: update hero section styles according to BEM methodology
nafisreza Oct 26, 2024
3e5b8e4
fix: hero__version-link
nafisreza Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,15 +93,15 @@

$intro = <<<EOF
<div class="hero">
<img class="hero-logo" src="/images/logos/php-logo-white.svg" alt="php" width="240" height="120">
<p class="hero-text">A <strong>popular general-purpose scripting language</strong> that is especially suited to web development.<br />Fast, flexible and pragmatic, PHP powers everything from your blog to the most popular websites in the world.</p>
<div class="hero-actions">
<a href="/releases/8.3/index.php" class="hero-btn hero-btn-primary">What's new in 8.3</a>
<a href="/downloads.php" class="hero-btn hero-btn-secondary">Download</a>
<img class="hero__logo" src="/images/logos/php-logo-white.svg" alt="php" width="240" height="120">
<p class="hero__text">A <strong>popular general-purpose scripting language</strong> that is especially suited to web development.<br />Fast, flexible and pragmatic, PHP powers everything from your blog to the most popular websites in the world.</p>
<div class="hero__actions">
<a href="/releases/8.3/index.php" class="hero__btn hero__btn--primary">What's new in 8.3</a>
<a href="/downloads.php" class="hero__btn hero__btn--secondary">Download</a>
</div>
EOF;

$intro .= "<ul class='hero-versions'>\n";
$intro .= "<ul class='hero__versions'>\n";
$active_branches = get_active_branches();
krsort($active_branches);
foreach ($active_branches as $major => $releases) {
Expand All @@ -110,7 +110,7 @@
$version = $release['version'];
[$major, $minor, $_] = explode('.', $version);
$intro .= "
<li class='hero-version'><a class='hero-version-link' href='/downloads.php#v$version'>$version</a> &middot; <a class='notes' href='/ChangeLog-$major.php#$version'>Changelog</a> &middot; <a class='notes' href='/migration$major$minor'>Upgrading</a></li>\n";
<li class='hero__version'><a class='hero__version-link' href='/downloads.php#v$version'>$version</a> &middot; <a class='notes' href='/ChangeLog-$major.php#$version'>Changelog</a> &middot; <a class='notes' href='/migration$major$minor'>Upgrading</a></li>\n";
}
}
$intro .= "</ul>\n";
Expand Down
48 changes: 24 additions & 24 deletions styles/home.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,32 +16,32 @@
margin: 32px 0;
}

.hero-logo {
.hero__logo {
width: 100%;
max-width: 240px;
margin-bottom: 24px;
}

.hero-text {
.hero__text {
margin-top: 0;
margin-bottom: 28px;
line-height: 1.5;
text-align: center;
text-rendering: optimizeLegibility;
}

.hero-text strong {
.hero__text strong {
font-weight: 500;
}

.hero-actions {
.hero__actions {
width: 100%;
display: flex;
flex-direction: column;
margin-bottom: 24px;
}

.hero-btn {
.hero__btn {
box-sizing: border-box;
padding: 16px 32px;
margin-bottom: 12px;
Expand All @@ -53,28 +53,28 @@
transition: background-color 0.2s;
}

.hero-btn-primary {
.hero__btn--primary {
background-color: var(--dark-blue-color);
color: #fff !important;
}

.hero-btn-primary:hover, .hero-btn-primary:focus {
.hero__btn--primary:hover, .hero__btn--primary:focus {
background-color: var(--dark-magenta-color);
}

.hero-btn-secondary {
.hero__btn--secondary {
background-color: transparent;
color: #b8c0e9 !important;
border: 1px solid #6773ad;
}

.hero-btn-secondary:hover, .hero-btn-secondary:focus {
.hero__btn--secondary:hover, .hero__btn--secondary:focus {
background-color: var(--dark-magenta-color);
border-color: var(--dark-magenta-color);
color: #fff !important;
}

.hero-versions {
.hero__versions {
margin: 0;
list-style:none;
display: flex;
Expand All @@ -85,41 +85,41 @@
width: 100%;
}

.hero-version {
.hero__version {
margin-bottom: 12px;
}

.hero-versions a.notes {
.hero__versions a.notes {
font-size:.875rem;
white-space:nowrap;
}

.hero-versions a {
.hero__versions a {
color: var(--background-text-color);
border:0;
}

.hero-versions a:hover,
.hero-versions a:focus {
.hero__versions a:hover,
.hero__versions a:focus {
border-bottom:1px dotted;
}

.hero-version-link {
.hero__version-link {
color:#fff !important;
display: inline-block;
}

@media (min-width: 540px) {
.hero-actions {
.hero__actions {
flex-direction: row;
width: auto;
}

.hero-btn {
.hero__btn {
min-width: 188px;
}

.hero-btn-secondary {
.hero__btn--secondary {
margin-left: 8px;
}
}
Expand All @@ -129,20 +129,20 @@
margin: 60px 0;
}

.hero-versions {
.hero__versions {
flex-direction: row;
}

.hero-version {
.hero__version {
font-size: 1.125rem;
padding: 0 1.5rem;
}

.hero-version:not(:first-child) {
.hero__version:not(:first-child) {
border-left: 1px dotted #666;
}

.hero-text {
.hero__text {
font-size: 18px;
}
}
Expand Down Expand Up @@ -213,7 +213,7 @@ aside.tips .social-media .icon-twitter {
color: #fff !important;
}

.btn-primary:hover, .hero-btn-primary:focus {
.btn-primary:hover, .hero__btn--primary:focus {
background-color: var(--dark-magenta-color) !important;
border-color: var(--dark-magenta-color) !important;
}
2 changes: 1 addition & 1 deletion tests/Visual/SmokeTest.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ const items: TestPageOptions[] = [
fullPage: true,
timeout: 10000,
},
mask: ['.hero-versions'],
mask: ['.hero__versions'],
},
{
path: 'archive/1998.php',
Expand Down