Correctly implement POST credentials method structure#432
Merged
k0ka merged 2 commits intophp-opencloud:credentialsfrom Nov 16, 2025
Merged
Correctly implement POST credentials method structure#432k0ka merged 2 commits intophp-opencloud:credentialsfrom
k0ka merged 2 commits intophp-opencloud:credentialsfrom
Conversation
bilboque
force-pushed
the
ec2-credentials
branch
from
54a2099 to
12ab91a
Compare
bilboque
force-pushed
the
ec2-credentials
branch
from
12ab91a to
3347c29
Compare
Member
|
Thank you for you contribution. However it doesn't make sense to change some typos without proper testing. I added integration tests and merged your PR into that branch. |
k0ka
added a commit
that referenced
this pull request
Nov 16, 2025
* fix: correct credentials structure (#432) * add integration tests for `Credential` Co-authored-by: Leo BONAZ <leo.bonaz.2002@gmail.com>
Contributor
Author
|
Thanks a lot for the fix and the tests :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The POST and PATCH params that we are sending should be in a credential object https://docs.openstack.org/api-ref/identity/v3/#credentials
The PR that tried to solved this issue is clearly abandonned #348