Conversation
Updated accuracy of AMP comparison. It supports much more of the listed features than were ticked.
WalkthroughUpdated docs/comparison.mdx to change the final-column statuses in competitor comparison tables from ❌ to ✅ for OAuth, Webhooks, Announcements, Themes, Plugins, Self update, and Remote Backups across both the main table and the “Our competitors” section. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for pelica ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (3)
docs/comparison.mdx (3)
106-106: Clarify what counts as “Announcements.”If AMP’s “announcements” are implemented via scheduled tasks/broadcasts rather than a first‑class announcements feature, add a brief note or footnote defining the criteria.
95-112: Add footnotes and an “as of” date to reduce disputes/churn.Given multiple competitor re‑ratings to ✅, add footnotes linking to AMP docs and an “As of YYYY‑MM‑DD/version” note under the table.
103-103: Rename row to "SSO (OAuth/OIDC)" and add a citation for AMP's OIDC supportCubeCoders documents OIDC/OAuth2 SSO (tested with Authentik); keep the ✅ and add the CubeCoders OIDC guide as a citation — Keycloak may require provider-specific tuning.
-| OAuth | ✅ | ❌ | ✅ | ✅ | ❌ | ❌ | ✅ | +| SSO (OAuth/OIDC) | ✅ | ❌ | ✅ | ✅ | ❌ | ❌ | ✅ |
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/comparison.mdx(1 hunks)
🔇 Additional comments (2)
docs/comparison.mdx (2)
107-107: Confirm: AMP includes first‑party themes (not just CSS overrides)AMP ships with a default first‑party theme and supports additional first‑party/community themes in the CubeCoders/AMP repository — see "Using AMP themes" (CubeCoders Knowledge Base) and the "Themes" directory in the CubeCoders/AMP GitHub repo.
104-104: Confirm AMP Webhooks support and add source linkAMP supports webhooks natively via the WebRequestPlugin and built-in Triggers — keep ✅; add a footnote/link to CubeCoders support/docs (https://support.cubecoders.com/ or the WebRequestPlugin forum thread) as the source.
|
When you say |
|
With AMP you can’t use your own themes – themes are only provided by the developer. |
Yes you can, they're just files in a directory - anyone can put them there. Normal CSS files that when put in the correct place and they're selectable. There's also a selection of 3rd party themes.
There are a couple - and more to the point, it has a plugin based architecture since it drives the internal functionality. So anyone who wanted to take advantage of that to write their own plugins to change things.
True for all practical purposes, it has localisation functionality but ships with no non-English locales at this time - so that can be crossed out.
Yes I was talking about in-server announcements (e.g. a scheduled message for all players saying the server is going down for maintenance). If we're only talking about what's in the panel itself then this should probably be clarified. Although we will have something akin to this in the public stream before this table is updated: |
4 participants
Updated accuracy of AMP comparison. It supports much more of the listed features than were ticked. AMP supports OAuth/OIDC login providers (Authentik, etc) - has webhooks, can do announcements (via the scheduler), has (and ships with) themes, its entire functionality set is plugin driven, it can update itself via the UI and supports S3/SFTP remote backups.
Summary by CodeRabbit